diff options
| author |   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2019-05-22 14:47:28 -0500 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2019-05-27 10:53:00 +0530 |
| commit | 2d35526df9b17db9a1e04d8eda538a44541dde66 (patch) | |
| tree | e366322d013895a6dc2d3a5f22d9a36a62006654 /drivers/soundwire | |
| parent | soundwire: cadence_master: log Slave status mask on errors (diff) | |
| download | linux-dev-2d35526df9b17db9a1e04d8eda538a44541dde66.tar.xz linux-dev-2d35526df9b17db9a1e04d8eda538a44541dde66.zip | |
soundwire: cadence_master: check the number of bidir PDIs
There is an assumption that the first two PDIs are reserved for Bulk,
so we need to make sure the number of bidir PDIs is indeed larger than
two. If the configuration provided is incorrect, this could lead to
allocating a huge amount of memory.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire')
| -rw-r--r-- | drivers/soundwire/cadence_master.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index d76dd24a6eae..ff4badc9b3de 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -718,6 +718,8 @@ int sdw_cdns_pdi_init(struct sdw_cdns *cdns, stream = &cdns->pcm; /* First two PDIs are reserved for bulk transfers */ + if (stream->num_bd < CDNS_PCM_PDI_OFFSET) + return -EINVAL; stream->num_bd -= CDNS_PCM_PDI_OFFSET; offset = CDNS_PCM_PDI_OFFSET; |