diff options
| author |   Richard Fitzgerald <rf@opensource.cirrus.com> | 2022-09-17 16:48:22 +0100 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-09-20 10:37:14 +0530 |
| commit | bafb1eacfbd98c6cdbca7e1723ef933ad371cd51 (patch) | |
| tree | 8f5356529e5b7703dfb65155a0f1ee2f1bd57d1a /drivers/soundwire | |
| parent | soundwire: cadence: Fix error check in cdns_xfer_msg() (diff) | |
| download | linux-dev-bafb1eacfbd98c6cdbca7e1723ef933ad371cd51.tar.xz linux-dev-bafb1eacfbd98c6cdbca7e1723ef933ad371cd51.zip | |
soundwire: cadence: Simplify error paths in cdns_xfer_msg()
There's no need to goto an exit label to return from cdns_xfer_msg().
It doesn't do any cleanup, only a return statement.
Replace the gotos with returns.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220917154822.690472-2-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire')
| -rw-r--r-- | drivers/soundwire/cadence_master.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index 3543a923ee6b..30b8c628fdbd 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -709,17 +709,14 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg) ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN, CDNS_MCP_CMD_LEN, false); if (ret != SDW_CMD_OK) - goto exit; + return ret; } if (!(msg->len % CDNS_MCP_CMD_LEN)) - goto exit; - - ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN, - msg->len % CDNS_MCP_CMD_LEN, false); + return SDW_CMD_OK; -exit: - return ret; + return _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN, + msg->len % CDNS_MCP_CMD_LEN, false); } EXPORT_SYMBOL(cdns_xfer_msg); |