diff options
| author |   Pan Bian <bianpan2016@163.com> | 2019-11-06 10:36:09 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-11-06 15:33:39 +0000 |
| commit | e9a8ba9769a0e354341bc6cc01b98aadcea1dfe9 (patch) | |
| tree | 51c8ac5432e22892130369920d98082d97fb88ad /drivers/spi/spi-img-spfi.c | |
| parent | spi: add power control when set_cs (diff) | |
| download | linux-dev-e9a8ba9769a0e354341bc6cc01b98aadcea1dfe9.tar.xz linux-dev-e9a8ba9769a0e354341bc6cc01b98aadcea1dfe9.zip | |
spi: img-spfi: fix potential double release
The channels spfi->tx_ch and spfi->rx_ch are not set to NULL after they
are released. As a result, they will be released again, either on the
error handling branch in the same function or in the corresponding
remove function, i.e. img_spfi_remove(). This patch fixes the bug by
setting the two members to NULL.
Signed-off-by: Pan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/1573007769-20131-1-git-send-email-bianpan2016@163.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-img-spfi.c')
| -rw-r--r-- | drivers/spi/spi-img-spfi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c index 439b01e4a2c8..f4a8f470aecc 100644 --- a/drivers/spi/spi-img-spfi.c +++ b/drivers/spi/spi-img-spfi.c @@ -673,6 +673,8 @@ static int img_spfi_probe(struct platform_device *pdev) dma_release_channel(spfi->tx_ch); if (spfi->rx_ch) dma_release_channel(spfi->rx_ch); + spfi->tx_ch = NULL; + spfi->rx_ch = NULL; dev_warn(spfi->dev, "Failed to get DMA channels, falling back to PIO mode\n"); } else { master->dma_tx = spfi->tx_ch; |