diff options
| author |   Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-02 22:58:35 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-11-10 15:59:10 +0000 |
| commit | 1dcbdd944824369d4569959f8130336fe6fe5f39 (patch) | |
| tree | c58807c050090d32c1d35c79d5cad8795d50616a /drivers/spi/spi-imx.c | |
| parent | spi: atmel-quadspi: Disable clock in probe error path (diff) | |
| download | linux-dev-1dcbdd944824369d4569959f8130336fe6fe5f39.tar.xz linux-dev-1dcbdd944824369d4569959f8130336fe6fe5f39.zip | |
spi: imx: fix reference leak in two imx operations
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in callers(spi_imx_prepare_message and
spi_imx_remove), so we should fix it.
Fixes: 525c9e5a32bd7 ("spi: imx: enable runtime pm support")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201102145835.4765-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-imx.c')
| -rw-r--r-- | drivers/spi/spi-imx.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 4b80e27ecdbf..8911465d8f47 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1538,6 +1538,7 @@ spi_imx_prepare_message(struct spi_master *master, struct spi_message *msg) ret = pm_runtime_get_sync(spi_imx->dev); if (ret < 0) { + pm_runtime_put_noidle(spi_imx->dev); dev_err(spi_imx->dev, "failed to enable clock\n"); return ret; } @@ -1747,6 +1748,7 @@ static int spi_imx_remove(struct platform_device *pdev) ret = pm_runtime_get_sync(spi_imx->dev); if (ret < 0) { + pm_runtime_put_noidle(spi_imx->dev); dev_err(spi_imx->dev, "failed to enable clock\n"); return ret; } |