diff options
| author |   Krzysztof Kozlowski <krzk@kernel.org> | 2020-09-01 17:27:12 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-09-08 18:19:30 +0100 |
| commit | 68fffc191ed19ea5618285b128e6048d1536e680 (patch) | |
| tree | 871c5cb36638e4237b68f4ca1fa80836855f5fa0 /drivers/spi/spi-tegra114.c | |
| parent | spi: synquacer: Simplify with dev_err_probe() (diff) | |
| download | linux-dev-68fffc191ed19ea5618285b128e6048d1536e680.tar.xz linux-dev-68fffc191ed19ea5618285b128e6048d1536e680.zip | |
spi: tegra114: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200901152713.18629-10-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-tegra114.c')
| -rw-r--r-- | drivers/spi/spi-tegra114.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index c2c58871a947..ca6886aaa519 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -664,16 +664,11 @@ static int tegra_spi_init_dma_param(struct tegra_spi_data *tspi, struct dma_chan *dma_chan; u32 *dma_buf; dma_addr_t dma_phys; - int ret; dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx"); - if (IS_ERR(dma_chan)) { - ret = PTR_ERR(dma_chan); - if (ret != -EPROBE_DEFER) - dev_err(tspi->dev, - "Dma channel is not available: %d\n", ret); - return ret; - } + if (IS_ERR(dma_chan)) + return dev_err_probe(tspi->dev, PTR_ERR(dma_chan), + "Dma channel is not available\n"); dma_buf = dma_alloc_coherent(tspi->dev, tspi->dma_buf_size, &dma_phys, GFP_KERNEL); |