diff options
| author |   Douglas Anderson <dianders@chromium.org> | 2020-12-17 14:29:14 -0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-12-18 17:42:17 +0000 |
| commit | 17fa81aa702ec118f2b835715897041675b06336 (patch) | |
| tree | fd9397abd2e6f897c4e7e013de1dec38927ec740 /drivers/spi | |
| parent | spi: spi-geni-qcom: Don't try to set CS if an xfer is pending (diff) | |
| download | linux-dev-17fa81aa702ec118f2b835715897041675b06336.tar.xz linux-dev-17fa81aa702ec118f2b835715897041675b06336.zip | |
spi: spi-geni-qcom: Print an error when we timeout setting the CS
If we're using geni to manage the chip select line (don't do it--use a
GPIO!) and we happen to get a timeout waiting for the chip select
command to be completed, no errors are printed even though things
might not be in the best shape. Let's add a print.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20201217142842.v3.4.I666b37646de9652cef438ac7c2c6c2053367fc6b@changeid
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-geni-qcom.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index 365565d3a998..881f645661cc 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -223,8 +223,10 @@ static void spi_geni_set_cs(struct spi_device *slv, bool set_flag) spin_unlock_irq(&mas->lock); time_left = wait_for_completion_timeout(&mas->cs_done, HZ); - if (!time_left) + if (!time_left) { + dev_warn(mas->dev, "Timeout setting chip select\n"); handle_fifo_timeout(spi, NULL); + } exit: pm_runtime_put(mas->dev); |