diff options
| author |   Chuhong Yuan <hslester96@gmail.com> | 2019-11-09 16:09:43 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-11-11 12:51:08 +0000 |
| commit | 5eb263ef08b5014cfc2539a838f39d2fd3531423 (patch) | |
| tree | 073a93c3ddf46568bf691e090a3f1471a762a3cb /drivers/spi | |
| parent | spi: nxp-fspi: Use devm API to fix missed unregistration of controller (diff) | |
| download | linux-dev-5eb263ef08b5014cfc2539a838f39d2fd3531423.tar.xz linux-dev-5eb263ef08b5014cfc2539a838f39d2fd3531423.zip | |
spi: pxa2xx: Add missed security checks
pxa2xx_spi_init_pdata misses checks for devm_clk_get and
platform_get_irq.
Add checks for them to fix the bugs.
Since ssp->clk and ssp->irq are used in probe, they are mandatory here.
So we cannot use _optional() for devm_clk_get and platform_get_irq.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20191109080943.30428-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-pxa2xx.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 6eb6805ee51d..9bc710c1b9e5 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1557,7 +1557,13 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) #endif ssp->clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(ssp->clk)) + return NULL; + ssp->irq = platform_get_irq(pdev, 0); + if (ssp->irq < 0) + return NULL; + ssp->type = type; ssp->dev = &pdev->dev; ssp->port_id = pxa2xx_spi_get_port_id(&pdev->dev); |