diff options
| author |   Dongliang Mu <mudongliangabcd@gmail.com> | 2021-07-20 18:01:16 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2021-07-22 16:02:22 +0100 |
| commit | 8311ee2164c5cd1b63a601ea366f540eae89f10e (patch) | |
| tree | 1aaf8817f0950986af9d75547e4079db4517904e /drivers/spi | |
| parent | spi: spi-mux: Add module info needed for autoloading (diff) | |
| download | linux-dev-8311ee2164c5cd1b63a601ea366f540eae89f10e.tar.xz linux-dev-8311ee2164c5cd1b63a601ea366f540eae89f10e.zip | |
spi: meson-spicc: fix memory leak in meson_spicc_remove
In meson_spicc_probe, the error handling code needs to clean up master
by calling spi_master_put, but the remove function does not have this
function call. This will lead to memory leak of spicc->master.
Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
Fixes: 454fa271bc4e("spi: Add Meson SPICC driver")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20210720100116.1438974-1-mudongliangabcd@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-meson-spicc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index b2c4621db34d..c208efeadd18 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -785,6 +785,8 @@ static int meson_spicc_remove(struct platform_device *pdev) clk_disable_unprepare(spicc->core); clk_disable_unprepare(spicc->pclk); + spi_master_put(spicc->master); + return 0; } |