diff options
| author |   Finn Thain <fthain@telegraphics.com.au> | 2019-03-16 14:21:19 +1100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-18 16:56:57 -0700 |
| commit | bb9e5c5bcd76f4474eac3baf643d7a39f7bac7bb (patch) | |
| tree | 14ad28530cd21c714a0ba951677611dab8861009 /drivers/spi | |
| parent | gtp: change NET_UDP_TUNNEL dependency to select (diff) | |
| download | linux-dev-bb9e5c5bcd76f4474eac3baf643d7a39f7bac7bb.tar.xz linux-dev-bb9e5c5bcd76f4474eac3baf643d7a39f7bac7bb.zip | |
mac8390: Fix mmio access size probe
The bug that Stan reported is as follows. After a restart, a 16-bit NIC
may be incorrectly identified as a 32-bit NIC and stop working.
mac8390 slot.E: Memory length resource not found, probing
mac8390 slot.E: Farallon EtherMac II-C (type farallon)
mac8390 slot.E: MAC 00:00:c5:30:c2:99, IRQ 61, 32 KB shared memory at 0xfeed0000, 32-bit access.
The bug never arises after a cold start and only intermittently after a
warm start. (I didn't investigate why the bug is intermittent.)
It turns out that memcpy_toio() is deprecated and memcmp_withio() also
has issues. Replacing these calls with mmio accessors fixes the problem.
Reported-and-tested-by: Stan Johnson <userm57@yahoo.com>
Fixes: 2964db0f5904 ("m68k: Mac DP8390 update")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/spi')
0 files changed, 0 insertions, 0 deletions