diff options
| author |   Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com> | 2021-08-24 11:25:56 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2021-08-24 20:53:24 +0100 |
| commit | ea4ab99cb58cc9f8d64c0961ff9a059825f304cf (patch) | |
| tree | dd8dbecb88b07dcaeff0bdfcfddb332c11a6fc6b /drivers/spi | |
| parent | spi: coldfire-qspi: Use clk_disable_unprepare in the remove function (diff) | |
| download | linux-dev-ea4ab99cb58cc9f8d64c0961ff9a059825f304cf.tar.xz linux-dev-ea4ab99cb58cc9f8d64c0961ff9a059825f304cf.zip | |
spi: davinci: invoke chipselect callback
Davinci needs to configure chipselect on transfer.
Fixes: 4a07b8bcd503 ("spi: bitbang: Make chipselect callback optional")
Signed-off-by: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Link: https://lore.kernel.org/r/735fb7b0-82aa-5b9b-85e4-53f0c348cc0e@nokia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-davinci.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index e114e6fe5ea5..d112c2cac042 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -213,12 +213,6 @@ static void davinci_spi_chipselect(struct spi_device *spi, int value) * line for the controller */ if (spi->cs_gpiod) { - /* - * FIXME: is this code ever executed? This host does not - * set SPI_MASTER_GPIO_SS so this chipselect callback should - * not get called from the SPI core when we are using - * GPIOs for chip select. - */ if (value == BITBANG_CS_ACTIVE) gpiod_set_value(spi->cs_gpiod, 1); else @@ -945,7 +939,7 @@ static int davinci_spi_probe(struct platform_device *pdev) master->bus_num = pdev->id; master->num_chipselect = pdata->num_chipselect; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(2, 16); - master->flags = SPI_MASTER_MUST_RX; + master->flags = SPI_MASTER_MUST_RX | SPI_MASTER_GPIO_SS; master->setup = davinci_spi_setup; master->cleanup = davinci_spi_cleanup; master->can_dma = davinci_spi_can_dma; |