aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/csr
diff options
context:
space:
mode:
authorPeter Huewe <peterhuewe@gmx.de>2013-01-26 00:19:19 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-29 23:22:16 -0500
commit2643c47fa4accb49abf46a1486909e20e4bb5df9 (patch)
tree22dd88401f7c6614f979c2ce7ab5d66640743f57 /drivers/staging/csr
parentstaging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE (diff)
downloadlinux-dev-2643c47fa4accb49abf46a1486909e20e4bb5df9.tar.xz
linux-dev-2643c47fa4accb49abf46a1486909e20e4bb5df9.zip
staging/csr: Use kmemdup rather than duplicating its implementation
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/csr')
-rw-r--r--drivers/staging/csr/drv.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/csr/drv.c b/drivers/staging/csr/drv.c
index 4780c32c2fe3..3bd52fdeac3b 100644
--- a/drivers/staging/csr/drv.c
+++ b/drivers/staging/csr/drv.c
@@ -819,15 +819,15 @@ unifi_write(struct file *filp, const char *p, size_t len, loff_t *poff)
unifi_trace(priv, UDBG2, "unifi_write: signal 0x%.4X len:%d\n",
sig_id, signal_size);
- /* Allocate a buffer for the signal */
- signal_buf = kmalloc(signal_size, GFP_KERNEL);
+ /* Allocate a buffer for the signal */
+ signal_buf = kmemdup(bulkdata.d[0].os_data_ptr, signal_size,
+ GFP_KERNEL);
if (!signal_buf) {
unifi_net_data_free(priv, &bulkdata.d[0]);
return -ENOMEM;
}
/* Get the signal from the os_data_ptr */
- memcpy(signal_buf, bulkdata.d[0].os_data_ptr, signal_size);
signal_buf[5] = (pcli->sender_id >> 8) & 0xff;
if (signal_size < len) {