diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2015-03-12 20:24:31 +0300 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-24 15:31:24 +0100 |
| commit | 4bef52f377b6410a89fc580a8948033f613854f8 (patch) | |
| tree | 037515e1fa5cfe94d88646696a58317e1d136ac2 /drivers/staging/dgnc/dgnc_cls.c | |
| parent | stating: octeon-usb: cvmx_usb_initialize(): eliminate extra indentation (diff) | |
| download | linux-dev-4bef52f377b6410a89fc580a8948033f613854f8.tar.xz linux-dev-4bef52f377b6410a89fc580a8948033f613854f8.zip | |
staging: dgnc: some off by one bugs
"dgnc_NumBoards" is the number of filled out elements in the
dgnc_Board[] array. "->nasync" and "->maxports" are the same value.
They are the number of channels in the ->channels[] array so these tests
should be ">=" instead of ">" so we avoid reading past the end of the
arrays.
I cleaned up the conditions in dgnc_mgmt_ioctl() a bit. There was a
work around for the off by one bug in the case where there were no
boards which is no longer needed. "channel" is unsigned so it can't be
negative.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dgnc/dgnc_cls.c')
| -rw-r--r-- | drivers/staging/dgnc/dgnc_cls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 66397d66ee0e..e3564d278d91 100644 --- a/drivers/staging/dgnc/dgnc_cls.c +++ b/drivers/staging/dgnc/dgnc_cls.c @@ -375,7 +375,7 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port) * verified in the interrupt routine. */ - if (port > brd->nasync) + if (port >= brd->nasync) return; ch = brd->channels[port]; |