diff options
| author |   Sheng Yong <shengyong1@huawei.com> | 2019-02-14 14:46:36 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-02-14 10:47:20 +0100 |
| commit | 3b1b5291f79d040d549d7c746669fc30e8045b9b (patch) | |
| tree | cd595c60fa6812dfe128afa61f3fdd99517d3a71 /drivers/staging/erofs | |
| parent | staging: rtl8192e: rename function cpMacAddr to copy_mac_addr - style (diff) | |
| download | linux-dev-3b1b5291f79d040d549d7c746669fc30e8045b9b.tar.xz linux-dev-3b1b5291f79d040d549d7c746669fc30e8045b9b.zip | |
staging: erofs: fix memleak of inode's shared xattr array
If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/erofs')
| -rw-r--r-- | drivers/staging/erofs/xattr.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c index e748df8d2b44..8c48b0ab31fd 100644 --- a/drivers/staging/erofs/xattr.c +++ b/drivers/staging/erofs/xattr.c @@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode) it.page = erofs_get_meta_page(sb, ++it.blkaddr, S_ISDIR(inode->i_mode)); - if (IS_ERR(it.page)) + if (IS_ERR(it.page)) { + kfree(vi->xattr_shared_xattrs); + vi->xattr_shared_xattrs = NULL; return PTR_ERR(it.page); + } it.kaddr = kmap_atomic(it.page); atomic_map = true; |