aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/et131x
diff options
context:
space:
mode:
authorMark Einon <mark.einon@gmail.com>2014-09-29 08:55:41 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-09-29 13:00:23 -0400
commit644bbf95f5e2937f4929866e0d8899a9ed42f691 (patch)
treedf759b78a6bdf96b40bdf2705b1ff693b8f76dbe /drivers/staging/et131x
parentstaging: et131x: Audit and update comments (diff)
downloadlinux-dev-644bbf95f5e2937f4929866e0d8899a9ed42f691.tar.xz
linux-dev-644bbf95f5e2937f4929866e0d8899a9ed42f691.zip
staging: et131x: Simplify for loop in et131x_init_send()
The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/et131x')
-rw-r--r--drivers/staging/et131x/et131x.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4973e6460e57..384dc163851b 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -1751,7 +1751,7 @@ static void et131x_disable_txrx(struct net_device *netdev)
static void et131x_init_send(struct et131x_adapter *adapter)
{
- u32 ct;
+ int i;
struct tx_ring *tx_ring = &adapter->tx_ring;
struct tcb *tcb = tx_ring->tcb_ring;
@@ -1759,8 +1759,10 @@ static void et131x_init_send(struct et131x_adapter *adapter)
memset(tcb, 0, sizeof(struct tcb) * NUM_TCB);
- for (ct = 0; ct++ < NUM_TCB; tcb++)
+ for (i = 0; i < NUM_TCB; i++) {
tcb->next = tcb + 1;
+ tcb++;
+ }
tcb--;
tx_ring->tcb_qtail = tcb;