aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/connection.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2016-07-19 17:21:27 +0200
committerGreg Kroah-Hartman <gregkh@google.com>2016-07-19 18:27:35 -0700
commit042fd749abab492ae02452cf675f7bc146814955 (patch)
treec6af2bd1807bfd888816e8ebde4d9e3745acf0e7 /drivers/staging/greybus/connection.c
parentgreybus: sdio: add switch voltage operation (diff)
downloadlinux-dev-042fd749abab492ae02452cf675f7bc146814955.tar.xz
linux-dev-042fd749abab492ae02452cf675f7bc146814955.zip
greybus: connection: drop the svc quiescing operation
Connection tear down is being reworked, and the SVC quiescing operation is going away. Let's remove this operation now along with the coupled second ping from our intermediate tear down implementation. This both avoids unnecessary noise in the logs resulting from the fact that the SVC side of the quiescing operation was never merged, and speeds up connection tear down slightly. Testing done: Tested on EVT2 using runtime PM. Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Sandeep Patil <sspatil@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/connection.c')
-rw-r--r--drivers/staging/greybus/connection.c19
1 files changed, 0 insertions, 19 deletions
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 174a52d5f524..634c8b1e92f3 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -417,21 +417,6 @@ gb_connection_svc_connection_destroy(struct gb_connection *connection)
connection->intf_cport_id);
}
-static void
-gb_connection_svc_connection_quiescing(struct gb_connection *connection)
-{
- struct gb_host_device *hd = connection->hd;
-
- if (gb_connection_is_static(connection))
- return;
-
- gb_svc_connection_quiescing(hd->svc,
- hd->svc->ap_intf_id,
- connection->hd_cport_id,
- connection->intf->interface_id,
- connection->intf_cport_id);
-}
-
/* Inform Interface about active CPorts */
static int gb_connection_control_connected(struct gb_connection *connection)
{
@@ -686,8 +671,6 @@ err_control_disconnecting:
gb_connection_ping(connection);
gb_connection_hd_cport_features_disable(connection);
- gb_connection_svc_connection_quiescing(connection);
- gb_connection_ping(connection);
gb_connection_control_disconnected(connection);
connection->state = GB_CONNECTION_STATE_DISABLED;
err_svc_connection_destroy:
@@ -795,8 +778,6 @@ void gb_connection_disable(struct gb_connection *connection)
gb_connection_ping(connection);
gb_connection_hd_cport_features_disable(connection);
- gb_connection_svc_connection_quiescing(connection);
- gb_connection_ping(connection);
gb_connection_control_disconnected(connection);