aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/greybus.h
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2015-09-17 13:17:27 +0200
committerGreg Kroah-Hartman <gregkh@google.com>2015-09-17 14:35:47 -0700
commit3afe952127e6379b32ba0d845231dbe952d6117b (patch)
tree5bb2b6c7cd84052e665fb0b33bb1fffae9f5d217 /drivers/staging/greybus/greybus.h
parentgreybus: hd: add optional cport enable and disable callbacks (diff)
downloadlinux-dev-3afe952127e6379b32ba0d845231dbe952d6117b.tar.xz
linux-dev-3afe952127e6379b32ba0d845231dbe952d6117b.zip
greybus: hd: remove connection-create/destroy callbacks
These host-driver callbacks were intended to allow host drivers to prepare a cport, something which can now be handled by the cport enable/disable callbacks instead. The current create/destroy are somewhat confusingly named as they were not supposed to create or destroy connections. They were however called from the unrelated helper functions that do create and destroy SVC connections. Furthermore, no errors were returned should the create callback fail, which should have caused the connection initialisation to fail. Remove these unused callbacks for now, and let us use the cport enable/disable callbacks that should be able handle all host cport initialisation (possibly after also adding an interface to provide information for endpoint-cport mapping). Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/greybus.h')
-rw-r--r--drivers/staging/greybus/greybus.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/greybus/greybus.h b/drivers/staging/greybus/greybus.h
index a320d58a219a..e4e53c139ac4 100644
--- a/drivers/staging/greybus/greybus.h
+++ b/drivers/staging/greybus/greybus.h
@@ -77,8 +77,6 @@ struct greybus_host_driver {
int (*cport_enable)(struct greybus_host_device *hd, u16 cport_id);
int (*cport_disable)(struct greybus_host_device *hd, u16 cport_id);
- void (*connection_create)(struct gb_connection *connection);
- void (*connection_destroy)(struct gb_connection *connection);
int (*message_send)(struct greybus_host_device *hd, u16 dest_cport_id,
struct gb_message *message, gfp_t gfp_mask);
void (*message_cancel)(struct gb_message *message);