diff options
| author |   Alex Elder <elder@linaro.org> | 2015-05-07 13:03:52 -0500 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@google.com> | 2015-05-07 22:57:31 +0200 |
| commit | 6d653370c0a67ff9b9b0d8249182d537859b528c (patch) | |
| tree | a7522c75f35a67ff55202eddb1b3f61809e551ab /drivers/staging/greybus/hid.c | |
| parent | greybus: battery: use feature tag rather than kernel version (diff) | |
| download | linux-dev-6d653370c0a67ff9b9b0d8249182d537859b528c.tar.xz linux-dev-6d653370c0a67ff9b9b0d8249182d537859b528c.zip | |
greybus: eliminate extra response flag definitions
All protocols use the same value to distinguish between request and
response message types. This is a requirement.
Use GB_MESSAGE_TYPE_RESPONSE rather than GB_OPERATION_TYPE_RESPONSE
for the name of the flag used to distiguish between request and
response messages.
Get rid of the redundant response flag definitions that are
associated with specific protocols.
Describe the symbolic values as "operation types" rather than
"message types" where they are defined. The message type for a
request is the same as the operation type; the message type for a
response is the operation type OR'd with GB_MESSAGE_TYPE_RESPONSE.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/hid.c')
| -rw-r--r-- | drivers/staging/greybus/hid.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c index 556cf9b0fe93..00dc7e57f4a4 100644 --- a/drivers/staging/greybus/hid.c +++ b/drivers/staging/greybus/hid.c @@ -20,7 +20,7 @@ #define GB_HID_VERSION_MAJOR 0x00 #define GB_HID_VERSION_MINOR 0x01 -/* Greybus HID request types */ +/* Greybus HID operation types */ #define GB_HID_TYPE_INVALID 0x00 #define GB_HID_TYPE_PROTOCOL_VERSION 0x01 #define GB_HID_TYPE_GET_DESC 0x02 @@ -30,7 +30,6 @@ #define GB_HID_TYPE_GET_REPORT 0x06 #define GB_HID_TYPE_SET_REPORT 0x07 #define GB_HID_TYPE_IRQ_EVENT 0x08 -#define GB_HID_TYPE_RESPONSE 0x80 /* OR'd with rest */ /* Report type */ #define GB_HID_INPUT_REPORT 0 |