diff options
| author |   Viresh Kumar <viresh.kumar@linaro.org> | 2016-02-12 16:08:26 +0530 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@google.com> | 2016-02-15 14:51:20 -0800 |
| commit | c463593c3dbc8d4dcb132538b0116256fa0cc455 (patch) | |
| tree | cd65979512bc7d31213e45fa5bd7331bf13a7360 /drivers/staging/greybus/raw.c | |
| parent | greybus: only build arche platform driver if usb3613 is enabled (diff) | |
| download | linux-dev-c463593c3dbc8d4dcb132538b0116256fa0cc455.tar.xz linux-dev-c463593c3dbc8d4dcb132538b0116256fa0cc455.zip | |
greybus: raw: Use consistent label names in connection_init()
Some of the labels are named based on what they are going to undo, while
others are based on where we failed in connection_init().
Follow only the first type of naming.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/raw.c')
| -rw-r--r-- | drivers/staging/greybus/raw.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/greybus/raw.c b/drivers/staging/greybus/raw.c index a6e795996053..d2e0281e86c5 100644 --- a/drivers/staging/greybus/raw.c +++ b/drivers/staging/greybus/raw.c @@ -174,21 +174,21 @@ static int gb_raw_connection_init(struct gb_connection *connection) cdev_init(&raw->cdev, &raw_fops); retval = cdev_add(&raw->cdev, raw->dev, 1); if (retval) - goto error_cdev; + goto error_remove_ida; raw->device = device_create(raw_class, &connection->bundle->dev, raw->dev, raw, "gb!raw%d", minor); if (IS_ERR(raw->device)) { retval = PTR_ERR(raw->device); - goto error_device; + goto error_del_cdev; } return 0; -error_device: +error_del_cdev: cdev_del(&raw->cdev); -error_cdev: +error_remove_ida: ida_simple_remove(&minors, minor); error_free: |