diff options
| author |   Lars-Peter Clausen <lars@metafoo.de> | 2012-09-22 09:56:00 +0100 |
|---|---|---|
| committer |   Jonathan Cameron <jic23@kernel.org> | 2012-09-22 10:17:28 +0100 |
| commit | 0b4ac3dce4093f426322be0eec0e38127a62bb7f (patch) | |
| tree | 03fe7b03c551de0941a7cf94feb2d838253fee7c /drivers/staging/iio | |
| parent | staging:iio:adis16200: Do not return a error in remove function (diff) | |
| download | linux-dev-0b4ac3dce4093f426322be0eec0e38127a62bb7f.tar.xz linux-dev-0b4ac3dce4093f426322be0eec0e38127a62bb7f.zip | |
staging:iio:adis16400: Do not return a error in remove function
In the Linux device driver model the remove callback is not allowed to fail and
the device will be removed regardless of the return value of the remove
callback. So if we abort in the remove function and do not free all resources we
will create a resource leak. Also all kinds of undefined behaviour are expected
to happen since the IIO device is still there while its parent is already gone.
The error which the driver tries to handle in the remove function is
non-critical, so we can just ignore it and continue to free all resources and
remove the IIO device.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/staging/iio')
| -rw-r--r-- | drivers/staging/iio/imu/adis16400_core.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/staging/iio/imu/adis16400_core.c b/drivers/staging/iio/imu/adis16400_core.c index b8c280cb8865..b302c9ba2712 100644 --- a/drivers/staging/iio/imu/adis16400_core.c +++ b/drivers/staging/iio/imu/adis16400_core.c @@ -1208,13 +1208,10 @@ error_ret: /* fixme, confirm ordering in this function */ static int __devexit adis16400_remove(struct spi_device *spi) { - int ret; struct iio_dev *indio_dev = spi_get_drvdata(spi); iio_device_unregister(indio_dev); - ret = adis16400_stop_device(indio_dev); - if (ret) - goto err_ret; + adis16400_stop_device(indio_dev); adis16400_remove_trigger(indio_dev); iio_buffer_unregister(indio_dev); @@ -1222,9 +1219,6 @@ static int __devexit adis16400_remove(struct spi_device *spi) iio_device_free(indio_dev); return 0; - -err_ret: - return ret; } static const struct spi_device_id adis16400_id[] = { |