diff options
| author |   Geordan Neukum <gneukum1@gmail.com> | 2019-06-05 01:09:13 +0000 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-06 15:05:02 +0200 |
| commit | 17dcc588d42b3e24a8482c60759201f138700ec0 (patch) | |
| tree | 37c8abf08b44e6f224fef51f81749cc0949d35cb /drivers/staging/kpc2000 | |
| parent | staging: kpc2000: kpc_spi: remove unnecessary ulong repr of i/o addr (diff) | |
| download | linux-dev-17dcc588d42b3e24a8482c60759201f138700ec0.tar.xz linux-dev-17dcc588d42b3e24a8482c60759201f138700ec0.zip | |
staging: kpc2000: kpc_spi: remove unnecessary cast in [read|write]_reg()
The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void
*) when invoking readq and writeq which both take a (void __iomem *) arg.
There is no need for this cast, and it actually harms us by discarding
the sparse cookie, __iomem. Make the driver stop performing this casting
operation.
Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/kpc2000')
| -rw-r--r-- | drivers/staging/kpc2000/kpc2000_spi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index 4f517afc6239..28132e9e260d 100644 --- a/drivers/staging/kpc2000/kpc2000_spi.c +++ b/drivers/staging/kpc2000/kpc2000_spi.c @@ -167,7 +167,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx) if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)){ return cs->conf_cache; } - val = readq((void*)addr); + val = readq(addr); return val; } @@ -176,7 +176,7 @@ kp_spi_write_reg(struct kp_spi_controller_state *cs, int idx, u64 val) { u64 __iomem *addr = cs->base; addr += idx; - writeq(val, (void*)addr); + writeq(val, addr); if (idx == KP_SPI_REG_CONFIG) cs->conf_cache = val; } |