diff options
author | Wambui Karuga <wambui.karugax@gmail.com> | 2019-10-09 20:07:03 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-10 10:44:50 +0200 |
commit | c0981afd8cd6e7176b4b9fe2186087695463ebde (patch) | |
tree | e1e279a1b2f620a28c8200fc10aba0d9787cbfb2 /drivers/staging/kpc2000 | |
parent | staging: comedi: Remove set but not used variable 'aref' (diff) | |
download | linux-dev-c0981afd8cd6e7176b4b9fe2186087695463ebde.tar.xz linux-dev-c0981afd8cd6e7176b4b9fe2186087695463ebde.zip |
staging: kpc2000: Remove unnecessary return variable
Remove unnecessary variable `val` in kp_spi_read_reg() that only holds
the return value from readq().
Issue found by coccinelle using the script:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191009170703.GA2869@wambui
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/kpc2000')
-rw-r--r-- | drivers/staging/kpc2000/kpc2000_spi.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index 3be33c450cab..6ba94b0131da 100644 --- a/drivers/staging/kpc2000/kpc2000_spi.c +++ b/drivers/staging/kpc2000/kpc2000_spi.c @@ -162,14 +162,12 @@ union kp_spi_ffctrl { kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx) { u64 __iomem *addr = cs->base; - u64 val; addr += idx; if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)) return cs->conf_cache; - val = readq(addr); - return val; + return readq(addr); } static inline void |