aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/lustre
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-06-08 14:53:20 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-06-08 12:39:48 -0700
commit2d78b3c1ec6299654d3857928db718c64e62d494 (patch)
tree8d695cd1417cba0d0a5c2ecef41b45fb57a1e1fb /drivers/staging/lustre
parentlustre: lov: Drop unneeded set_oabufs and set_pga fields (diff)
downloadlinux-dev-2d78b3c1ec6299654d3857928db718c64e62d494.tar.xz
linux-dev-2d78b3c1ec6299654d3857928db718c64e62d494.zip
lustre: lov: Drop rq_buflen field
The rq_buflen field of the lov_request structure is never initialized. It is only used in the free of req->rq_oi.oi_md in lov_finish_set. But no oi_md field is ever initialized to the result of calling OBD_ALLOC_LARGE. So it seems that the call to OBD_FREE_LARGE in lov_finish_set and the rq_buflen in the lov_request structure are simply not needed. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/lustre')
-rw-r--r--drivers/staging/lustre/lustre/lov/lov_internal.h1
-rw-r--r--drivers/staging/lustre/lustre/lov/lov_request.c2
2 files changed, 0 insertions, 3 deletions
diff --git a/drivers/staging/lustre/lustre/lov/lov_internal.h b/drivers/staging/lustre/lustre/lov/lov_internal.h
index e4e0cfdfd8ea..dde9656d4dd6 100644
--- a/drivers/staging/lustre/lustre/lov/lov_internal.h
+++ b/drivers/staging/lustre/lustre/lov/lov_internal.h
@@ -81,7 +81,6 @@ struct lov_request {
int rq_stripe; /* stripe number */
int rq_complete;
int rq_rc;
- int rq_buflen; /* length of sub_md */
u32 rq_oabufs;
u32 rq_pgaidx;
diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c
index ada0a3cf1c0f..f4f2058abd2b 100644
--- a/drivers/staging/lustre/lustre/lov/lov_request.c
+++ b/drivers/staging/lustre/lustre/lov/lov_request.c
@@ -68,8 +68,6 @@ void lov_finish_set(struct lov_request_set *set)
if (req->rq_oi.oi_oa)
OBDO_FREE(req->rq_oi.oi_oa);
- if (req->rq_oi.oi_md)
- OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);
kfree(req->rq_oi.oi_osfs);
kfree(req);
}