diff options
author | Tom Rix <trix@redhat.com> | 2022-03-19 15:34:56 +0100 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2022-05-13 11:02:18 +0200 |
commit | 6bf9691159e5e5111c91478888524c5396a9ce9e (patch) | |
tree | 95febd35ff3b954f17abb304936323be43f9d302 /drivers/staging/media/av7110/av7110_av.c | |
parent | media: exynos4-is: Change clk_disable to clk_disable_unprepare (diff) | |
download | linux-dev-6bf9691159e5e5111c91478888524c5396a9ce9e.tar.xz linux-dev-6bf9691159e5e5111c91478888524c5396a9ce9e.zip |
media: platform: return early if the iface is not handled
Clang static analysis reports this issue
ispcsiphy.c:63:14: warning: The left operand of '<<'
is a garbage value
reg |= mode << shift;
~~~~ ^
The iface switch-statement default case falls through
to ISP_INTERFACE_CCP2B_PHY1. Which is later checked
to set the mode. Since the default case is left out
of this check mode is never set. Instead of falling
through and assuming a ISP_INTERFACE_CCP2B_PHY1
iface, return.
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/staging/media/av7110/av7110_av.c')
0 files changed, 0 insertions, 0 deletions