diff options
| author |   Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-04-11 08:27:59 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-04-17 05:49:59 -0400 |
| commit | e935dbfc9ff8787ea2d592898d3c32407a87f365 (patch) | |
| tree | 5f5607a0d9bf8aa8538aaf0f7a52f6c66877223c /drivers/staging/media | |
| parent | media: cec: fix smatch error (diff) | |
| download | linux-dev-e935dbfc9ff8787ea2d592898d3c32407a87f365.tar.xz linux-dev-e935dbfc9ff8787ea2d592898d3c32407a87f365.zip | |
media: atomisp: remove an impossible condition
Changeset dc9f65cf9aea ("media: staging: atomisp: avoid a warning if 32
bits build") was meant to solve an impossible condition when building
with 32 bits. It turns that this impossible condition also happens wit
64 bits:
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:698 gmin_get_config_var() warn: impossible condition '(*out_len > (~0)) => (0-u64max > u64max)'
After a further analysis, this condition will always be false as, on
all architectures, size_t doesn't have more bits than unsigned long.
Also, the only two archs that really matter are x86 and x86_64, as this
driver doesn't build on other archs (as it depends on X86-specific UEFI
support).
So, just drop the useless code.
Fixes: dc9f65cf9aea ("media: staging: atomisp: avoid a warning if 32 bits build")
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/staging/media')
| -rw-r--r-- | drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c index 3283c1b05d6a..70c34de98707 100644 --- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c @@ -693,12 +693,6 @@ static int gmin_get_config_var(struct device *dev, const char *var, for (i = 0; i < sizeof(var8) && var8[i]; i++) var16[i] = var8[i]; -#ifdef CONFIG_64BIT - /* To avoid owerflows when calling the efivar API */ - if (*out_len > ULONG_MAX) - return -EINVAL; -#endif - /* Not sure this API usage is kosher; efivar_entry_get()'s * implementation simply uses VariableName and VendorGuid from * the struct and ignores the rest, but it seems like there |