diff options
| author |   George Edward Bulmer <gebulmer@googlemail.com> | 2017-12-29 21:26:20 +0000 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-01-08 16:36:00 +0100 |
| commit | 6724ed7f28d6e83956a7219a9a02a4d620ef65d8 (patch) | |
| tree | dd9141ff6f7a4d02720b5933ef1dedb6bd3a9836 /drivers/staging/most | |
| parent | staging: most: Fix identifiers to function parameters (diff) | |
| download | linux-dev-6724ed7f28d6e83956a7219a9a02a4d620ef65d8.tar.xz linux-dev-6724ed7f28d6e83956a7219a9a02a4d620ef65d8.zip | |
staging: most: convert macro to static function
This fixes checkpatch warning:
CHECK: Macro argument reuse 'buf' - possible side effects?
Signed-off-by: George Edward Bulmer <gebulmer@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/most')
| -rw-r--r-- | drivers/staging/most/net/net.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c index 33606584e50e..30d816b7e165 100644 --- a/drivers/staging/most/net/net.c +++ b/drivers/staging/most/net/net.c @@ -46,10 +46,12 @@ ((len) > MEP_HDR_LEN && \ EXTRACT_BIT_SET(PMS_FIFONO, (buf)[3]) == PMS_FIFONO_MEP) -#define PMS_IS_MAMAC(buf, len) \ - ((len) > MDP_HDR_LEN && \ - EXTRACT_BIT_SET(PMS_FIFONO, (buf)[3]) == PMS_FIFONO_MDP && \ - EXTRACT_BIT_SET(PMS_TELID, (buf)[14]) == PMS_TELID_UNSEGM_MAMAC) +static inline bool pms_is_mamac(char *buf, u32 len) +{ + return (len > MDP_HDR_LEN && + EXTRACT_BIT_SET(PMS_FIFONO, buf[3]) == PMS_FIFONO_MDP && + EXTRACT_BIT_SET(PMS_TELID, buf[14]) == PMS_TELID_UNSEGM_MAMAC); +} struct net_dev_channel { bool linked; @@ -435,7 +437,7 @@ static int comp_rx_data(struct mbo *mbo) dev = nd->dev; if (nd->is_mamac) { - if (!PMS_IS_MAMAC(buf, len)) { + if (!pms_is_mamac(buf, len)) { ret = -EIO; goto put_nd; } |