diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2018-03-22 02:10:07 +0000 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-03-22 18:31:04 +0100 |
| commit | 3eb3c3e32eef50e3a3375bf1636e05f5ec4b1210 (patch) | |
| tree | 2827962276b5c87b6f9918036589d1e59dacc1c7 /drivers/staging/mt7621-eth | |
| parent | staging: mt7621-eth: fix return value check in mtk_connect_phy_node() (diff) | |
| download | linux-dev-3eb3c3e32eef50e3a3375bf1636e05f5ec4b1210.tar.xz linux-dev-3eb3c3e32eef50e3a3375bf1636e05f5ec4b1210.zip | |
staging: mt7621-eth: fix return value check in mt7621_gsw_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: f079b6406348 ("staging: mt7621-eth: add gigabit switch driver (GSW)")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/mt7621-eth')
| -rw-r--r-- | drivers/staging/mt7621-eth/gsw_mt7621.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/mt7621-eth/gsw_mt7621.c b/drivers/staging/mt7621-eth/gsw_mt7621.c index b49ee946e6bd..ce8d7d7577c7 100644 --- a/drivers/staging/mt7621-eth/gsw_mt7621.c +++ b/drivers/staging/mt7621-eth/gsw_mt7621.c @@ -263,8 +263,8 @@ static int mt7621_gsw_probe(struct platform_device *pdev) return -ENOMEM; gsw->base = devm_ioremap_resource(&pdev->dev, res); - if (!gsw->base) - return -EADDRNOTAVAIL; + if (IS_ERR(gsw->base)) + return PTR_ERR(gsw->base); gsw->dev = &pdev->dev; gsw->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); |