aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/mt7621-mmc
diff options
context:
space:
mode:
authorSumit Pundir <pundirsumit11@gmail.com>2018-08-10 18:01:40 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-08-27 19:31:59 +0200
commitb9e50d0cfd32274df6a057a59cb0695ae828fa2b (patch)
tree4ff78b78b954fcd9f327877a2af64adb57b2790e /drivers/staging/mt7621-mmc
parentstaging: rtl8188eu: Removed unneeded variable (diff)
downloadlinux-dev-b9e50d0cfd32274df6a057a59cb0695ae828fa2b.tar.xz
linux-dev-b9e50d0cfd32274df6a057a59cb0695ae828fa2b.zip
staging: mt7621-mmc: place a check for sscanf
Placed a check for the return value of sscanf. -EINVAL is returned if the value is anything other than expected. Reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/mt7621-mmc')
-rw-r--r--drivers/staging/mt7621-mmc/dbg.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
index 6e518dce9029..4fe4d2fd111e 100644
--- a/drivers/staging/mt7621-mmc/dbg.c
+++ b/drivers/staging/mt7621-mmc/dbg.c
@@ -249,7 +249,9 @@ static ssize_t msdc_debug_proc_write(struct file *file,
cmd_buf[count] = '\0';
pr_debug("msdc Write %s\n", cmd_buf);
- sscanf(cmd_buf, "%x %x %x", &cmd, &p1, &p2);
+ ret = sscanf(cmd_buf, "%x %x %x", &cmd, &p1, &p2);
+ if (ret != 3)
+ return -EINVAL;
if (cmd == SD_TOOL_ZONE) {
id = p1;