diff options
| author |   Takashi Iwai <tiwai@suse.de> | 2019-09-14 17:24:05 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-01 08:22:44 +0200 |
| commit | 2eed19b99c8e95ff87afe6c140ed895c3fac5937 (patch) | |
| tree | b1bd3117d57bb0192796dd44896a17e6ece37b73 /drivers/staging/mt7621-pci | |
| parent | staging/fbtft: Remove flexfb (diff) | |
| download | linux-dev-2eed19b99c8e95ff87afe6c140ed895c3fac5937.tar.xz linux-dev-2eed19b99c8e95ff87afe6c140ed895c3fac5937.zip | |
staging: bcm2835-audio: Fix draining behavior regression
The PCM draining behavior got broken since the recent refactoring, and
this turned out to be the incorrect expectation of the firmware
behavior regarding "draining". While I expected the "drain" flag at
the stop operation would do processing the queued samples, it seems
rather dropping the samples.
As a quick fix, just drop the SNDRV_PCM_INFO_DRAIN_TRIGGER flag, so
that the driver uses the normal PCM draining procedure. Also, put
some caution comment to the function for future readers not to fall
into the same pitfall.
Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops")
BugLink: https://github.com/raspberrypi/linux/issues/2983
Cc: stable@vger.kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20190914152405.7416-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/mt7621-pci')
0 files changed, 0 insertions, 0 deletions