diff options
| author |   Marc Dietrich <marvin24@gmx.de> | 2011-09-27 19:00:41 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@suse.de> | 2011-09-29 17:40:37 -0700 |
| commit | a3a9aa1a41429b17aa1af20995850ea1b68d5ba2 (patch) | |
| tree | a94b9a57d3bd5fea37abafd0b84b3fc18ed1c0dc /drivers/staging/nvec | |
| parent | staging: nvec: coding style fixes / add copyright notice (diff) | |
| download | linux-dev-a3a9aa1a41429b17aa1af20995850ea1b68d5ba2.tar.xz linux-dev-a3a9aa1a41429b17aa1af20995850ea1b68d5ba2.zip | |
staging: nvec: Use print_hex_dump() where appropriate
Split of the previous patch and the next by Marc, as that
patch is not strictly a coding style fix only.
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/nvec')
| -rw-r--r-- | drivers/staging/nvec/nvec.c | 20 |
1 files changed, 7 insertions, 13 deletions
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index d8609abcbd26..d43fba25c22d 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -76,15 +76,13 @@ static int nvec_status_notifier(struct notifier_block *nb, unsigned long event_type, void *data) { unsigned char *msg = (unsigned char *)data; - int i; if (event_type != NVEC_CNTL) return NOTIFY_DONE; - printk(KERN_WARNING "unhandled msg type %ld, payload: ", event_type); - for (i = 0; i < msg[1]; i++) - printk("%0x ", msg[i+2]); - printk("\n"); + printk(KERN_WARNING "unhandled msg type %ld\n", event_type); + print_hex_dump(KERN_WARNING, "payload: ", DUMP_PREFIX_NONE, 16, 1, + msg, msg[1] + 2, true); return NOTIFY_OK; } @@ -117,20 +115,16 @@ static void nvec_request_master(struct work_struct *work) static int parse_msg(struct nvec_chip *nvec, struct nvec_msg *msg) { - int i; - if ((msg->data[0] & 1 << 7) == 0 && msg->data[3]) { dev_err(nvec->dev, "ec responded %02x %02x %02x %02x\n", msg->data[0], msg->data[1], msg->data[2], msg->data[3]); return -EINVAL; } - if ((msg->data[0] >> 7) == 1 && (msg->data[0] & 0x0f) == 5) { - dev_warn(nvec->dev, "ec system event "); - for (i = 0; i < msg->data[1]; i++) - dev_warn(nvec->dev, "%02x ", msg->data[2+i]); - dev_warn(nvec->dev, "\n"); - } + if ((msg->data[0] >> 7) == 1 && (msg->data[0] & 0x0f) == 5) + print_hex_dump(KERN_WARNING, "ec system event ", + DUMP_PREFIX_NONE, 16, 1, msg->data, + msg->data[1] + 2, true); atomic_notifier_call_chain(&nvec->notifier_list, msg->data[0] & 0x8f, msg->data); |