aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/pi433
diff options
context:
space:
mode:
authorNishka Dasgupta <nishkadg.linux@gmail.com>2019-05-23 18:23:41 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-24 09:00:44 +0200
commit48c80ccce63ff50f17b774131c9bd1cdb875d305 (patch)
tree3c3d0757e7ce61a46b8cbed315e79582a0d275e5 /drivers/staging/pi433
parentstaging: kpc2000: remove invalid spaces in cell_probe.c (diff)
downloadlinux-dev-48c80ccce63ff50f17b774131c9bd1cdb875d305.tar.xz
linux-dev-48c80ccce63ff50f17b774131c9bd1cdb875d305.zip
staging: pi433: Remove unnecessary variable
The variable retval is assigned constant values twice, and can therefore be replaced by its values. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/pi433')
-rw-r--r--drivers/staging/pi433/pi433_if.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index c889f0bdf424..40c6f4e7632f 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -871,7 +871,6 @@ abort:
static long
pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
{
- int retval = 0;
struct pi433_instance *instance;
struct pi433_device *device;
struct pi433_tx_cfg tx_cfg;
@@ -923,10 +922,10 @@ pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
mutex_unlock(&device->rx_lock);
break;
default:
- retval = -EINVAL;
+ return -EINVAL;
}
- return retval;
+ return 0;
}
#ifdef CONFIG_COMPAT