aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/qlge/qlge_dbg.c
diff options
context:
space:
mode:
authorBenjamin Poirier <bpoirier@suse.com>2019-09-27 19:12:04 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-04 17:17:46 +0200
commite4c911a73c8948a679981c2001c0aed9d0054ab1 (patch)
tree07ae252fec81b3c2bb2783eade87a41ed9f17774 /drivers/staging/qlge/qlge_dbg.c
parentstaging: qlge: Fix dma_sync_single calls (diff)
downloadlinux-dev-e4c911a73c8948a679981c2001c0aed9d0054ab1.tar.xz
linux-dev-e4c911a73c8948a679981c2001c0aed9d0054ab1.zip
staging: qlge: Remove rx_ring.type
This field is redundant, the type can be determined from the index, cq_id. Signed-off-by: Benjamin Poirier <bpoirier@suse.com> Link: https://lore.kernel.org/r/20190927101210.23856-11-bpoirier@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/qlge/qlge_dbg.c')
-rw-r--r--drivers/staging/qlge/qlge_dbg.c16
1 files changed, 12 insertions, 4 deletions
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index e8ad8209d487..81fbee7f2af6 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1730,16 +1730,24 @@ void ql_dump_cqicb(struct cqicb *cqicb)
le16_to_cpu(cqicb->sbq_len));
}
+static const char *qlge_rx_ring_type_name(struct rx_ring *rx_ring)
+{
+ struct ql_adapter *qdev = rx_ring->qdev;
+
+ if (rx_ring->cq_id < qdev->rss_ring_count)
+ return "RX COMPLETION";
+ else
+ return "TX COMPLETION";
+};
+
void ql_dump_rx_ring(struct rx_ring *rx_ring)
{
if (rx_ring == NULL)
return;
pr_err("===================== Dumping rx_ring %d ===============\n",
rx_ring->cq_id);
- pr_err("Dumping rx_ring %d, type = %s%s%s\n",
- rx_ring->cq_id, rx_ring->type == DEFAULT_Q ? "DEFAULT" : "",
- rx_ring->type == TX_Q ? "OUTBOUND COMPLETIONS" : "",
- rx_ring->type == RX_Q ? "INBOUND_COMPLETIONS" : "");
+ pr_err("Dumping rx_ring %d, type = %s\n", rx_ring->cq_id,
+ qlge_rx_ring_type_name(rx_ring));
pr_err("rx_ring->cqicb = %p\n", &rx_ring->cqicb);
pr_err("rx_ring->cq_base = %p\n", rx_ring->cq_base);
pr_err("rx_ring->cq_base_dma = %llx\n",