diff options
| author |   Phillip Potter <phil@philpotter.co.uk> | 2021-05-25 22:48:13 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-27 12:31:07 +0200 |
| commit | 7f8d698ffb17d7880af6316361f267a6921d218b (patch) | |
| tree | be19e25b4ccfbb515905be29a0a0c237e0435cf9 /drivers/staging/rtl8188eu/hal | |
| parent | Staging: rtl8723bs: fixed a blank coding style (diff) | |
| download | linux-dev-7f8d698ffb17d7880af6316361f267a6921d218b.tar.xz linux-dev-7f8d698ffb17d7880af6316361f267a6921d218b.zip | |
staging: rtl8188eu: convert pr_info call to dev_err call ODM_RAStateCheck
Introduce logic to extract struct device pointer from passed in struct
odm_dm_struct pointer argument, and use this to call dev_err instead of
pr_info. As this is an error state if this line is reached, this is not
just information. Also, this is a driver, so dev_err is more
appropriate.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210525214813.6362-1-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8188eu/hal')
| -rw-r--r-- | drivers/staging/rtl8188eu/hal/odm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index b800d0c6dff5..8348e02b4c86 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b/drivers/staging/rtl8188eu/hal/odm.c @@ -808,6 +808,7 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate u8 HighRSSIThreshForRA = pRA->HighRSSIThresh; u8 LowRSSIThreshForRA = pRA->LowRSSIThresh; u8 RATRState; + struct device *dev = dvobj_to_dev(adapter_to_dvobj(pDM_Odm->Adapter)); /* Threshold Adjustment: */ /* when RSSI state trends to go up one or two levels, make sure RSSI is high enough. */ @@ -824,7 +825,7 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate LowRSSIThreshForRA += GoUpGap; break; default: - pr_info("%s(): wrong rssi level setting %d!\n", __func__, *pRATRState); + dev_err(dev, "%s(): wrong rssi level setting %d!\n", __func__, *pRATRState); break; } |