aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8192e
diff options
context:
space:
mode:
authorMitali Borkar <mitaliborkar810@gmail.com>2021-04-10 20:26:40 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-04-11 08:36:13 +0200
commit26be3a5d845312bae0397b1008e766340945cb53 (patch)
tree9fb2d5a49a37176d6f8f4261b172f62ac73e2457 /drivers/staging/rtl8192e
parentstaging: comedi: tests: ni_routes_test: Remove unused variable 'olddevroutes' (diff)
downloadlinux-dev-26be3a5d845312bae0397b1008e766340945cb53.tar.xz
linux-dev-26be3a5d845312bae0397b1008e766340945cb53.zip
staging: rtl8192e: Fix incorrect pointer check
In commit 92172da23c56 ("staging: rtl8192e: replace comparison to NULL by bool") a check was changed from looking at the data to the pointer, which was incorrect, so revert that portion of the commit to have the proper logic restored. Reported-by: Julia Lawall <julia.lawall@inria.fr> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com> Fixes: 92172da23c56 ("staging: rtl8192e: replace comparison to NULL by bool") Link: https://lore.kernel.org/r/YHG8qARLUX2KPWwI@kali Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8192e')
-rw-r--r--drivers/staging/rtl8192e/rtl819x_TSProc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 744a06b30d51..6c51323104e5 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -329,7 +329,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
}
*ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
- if (ppTS)
+ if (*ppTS)
return true;
if (!bAddNewTs) {