aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8192u/r8192U_dm.h
diff options
context:
space:
mode:
authorJohn Whitmore <johnfwhitmore@gmail.com>2018-08-03 01:02:05 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-08-05 16:21:07 +0200
commitd3c90eff9c4ed66a9f16db2ef99b75455a850e7b (patch)
tree9f105e483a0ce0f37a3c32e7e253674bb1f55c85 /drivers/staging/rtl8192u/r8192U_dm.h
parentstaging:rtl8192u: Remove member reserved - Style (diff)
downloadlinux-dev-d3c90eff9c4ed66a9f16db2ef99b75455a850e7b.tar.xz
linux-dev-d3c90eff9c4ed66a9f16db2ef99b75455a850e7b.zip
staging:rtl8192u: Refactor DCMD_TXCMD_T structure - Style
The structure DCMD_TXCMD_T is declared with a typedef, which causes a checkpatch issue with defining new types. As a result the typedef has been removed. The structure's name DCMD_TXCMD_T, as a type, is meant to be lowercase so has been renamed to tx_config_cmd. The structures three members, (Op, Length, and Value) are all violating the coding standard policy on CamelCase naming, so have all been renamed. They have been renamed with longer names, (cmd_op, cmd_length and cmd_value), to make the variable names easier to search for in code. The magic numbers '4' and '12' have both been replaced with sizeof() calls, as they both represent the size of data elements. These are coding style changes which should have no impact on runtime code execution. Signed-off-by: John Whitmore <johnfwhitmore@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8192u/r8192U_dm.h')
-rw-r--r--drivers/staging/rtl8192u/r8192U_dm.h11
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 66dfcbbf6e43..9a0105412350 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -139,11 +139,12 @@ struct dynamic_rx_path_sel {
long cck_pwdb_sta[4];
};
-typedef struct tag_Tx_Config_Cmd_Format {
- u32 Op; /* Command packet type. */
- u32 Length; /* Command packet length. */
- u32 Value;
-} DCMD_TXCMD_T, *PDCMD_TXCMD_T;
+struct tx_config_cmd {
+ u32 cmd_op; /* Command packet type. */
+ u32 cmd_length; /* Command packet length. */
+ u32 cmd_value;
+};
+
/*------------------------------Define structure----------------------------*/