diff options
| author |   Larry Finger <Larry.Finger@lwfinger.net> | 2017-09-23 19:36:04 -0500 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-10-18 15:33:15 +0200 |
| commit | 43d15c2013130a9fa230c2f5203aca818ae0bb86 (patch) | |
| tree | 5a09eafca0654b8751b84d520e3bdadf54a90661 /drivers/staging/rtlwifi | |
| parent | staging: ccree: fix boolreturn.cocci warning (diff) | |
| download | linux-dev-43d15c2013130a9fa230c2f5203aca818ae0bb86.tar.xz linux-dev-43d15c2013130a9fa230c2f5203aca818ae0bb86.zip | |
staging: rtl8822be: Keep array subscript no lower than zero
The kbuild test robot reports the following:
drivers/staging//rtlwifi/phydm/phydm_dig.c: In function 'odm_pause_dig':
drivers/staging//rtlwifi/phydm/phydm_dig.c:494:45: warning: array subscript is below array bounds [-Warray-bounds]
odm_write_dig(dm, dig_tab->pause_dig_value[max_level]);
This condition is caused when a loop falls through. The fix is to pin
max_level to be >= 0.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
c: kbuild test robot <fengguang.wu@intel.com>
Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add phydm mini driver
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtlwifi')
| -rw-r--r-- | drivers/staging/rtlwifi/phydm/phydm_dig.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/rtlwifi/phydm/phydm_dig.c b/drivers/staging/rtlwifi/phydm/phydm_dig.c index 31a4f3fcad19..c88b9788363a 100644 --- a/drivers/staging/rtlwifi/phydm/phydm_dig.c +++ b/drivers/staging/rtlwifi/phydm/phydm_dig.c @@ -490,6 +490,8 @@ void odm_pause_dig(void *dm_void, enum phydm_pause_type pause_type, break; } + /* pin max_level to be >= 0 */ + max_level = max_t(s8, 0, max_level); /* write IGI of lower level */ odm_write_dig(dm, dig_tab->pause_dig_value[max_level]); ODM_RT_TRACE(dm, ODM_COMP_DIG, |