diff options
| author |   Aditya Pakki <pakki001@umn.edu> | 2018-12-27 13:35:53 -0600 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-07 08:56:07 +0100 |
| commit | 73b69c01cc925d9c48e5b4f78e3d8b88c4e5b924 (patch) | |
| tree | 643e2e7477bf1f4f2cb57da2af9abdac8555e272 /drivers/staging/rts5208/ms.c | |
| parent | staging: fsl-dpaa2: fix SPDX identifiers in header files (diff) | |
| download | linux-dev-73b69c01cc925d9c48e5b4f78e3d8b88c4e5b924.tar.xz linux-dev-73b69c01cc925d9c48e5b4f78e3d8b88c4e5b924.zip | |
staging: rts5208: Add a check for ms_read_extra_data
In ms_copy_page, the function ms_read_extra_data may fail for many
reasons. The fix adds a check similar to other invocation to return
error upstream.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rts5208/ms.c')
| -rw-r--r-- | drivers/staging/rts5208/ms.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index e43f92080c20..1128eec3bd08 100644 --- a/drivers/staging/rts5208/ms.c +++ b/drivers/staging/rts5208/ms.c @@ -1665,7 +1665,10 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk, return STATUS_FAIL; } - ms_read_extra_data(chip, old_blk, i, extra, MS_EXTRA_SIZE); + retval = ms_read_extra_data(chip, old_blk, i, extra, + MS_EXTRA_SIZE); + if (retval != STATUS_SUCCESS) + return STATUS_FAIL; retval = ms_set_rw_reg_addr(chip, OverwriteFlag, MS_EXTRA_SIZE, SystemParm, 6); |