diff options
| author |   Kulikov Vasiliy <segooon@gmail.com> | 2010-06-27 17:20:46 +0400 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@suse.de> | 2010-07-08 13:16:43 -0700 |
| commit | 3746bfd51d8108d43c06064481065afc07bbcc1d (patch) | |
| tree | eb2aa06d9bd8e5df2e8e91781e76717d5a9d144b /drivers/staging/slicoss | |
| parent | staging: slicoss: Remove STATUS_XXX defines. (diff) | |
| download | linux-dev-3746bfd51d8108d43c06064481065afc07bbcc1d.tar.xz linux-dev-3746bfd51d8108d43c06064481065afc07bbcc1d.zip | |
staging: slicoss: error handling with goto
This patch makes error handling more readable due to 'goto err' pattern.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Cc: Denis Kirjanov <kirjanov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/slicoss')
| -rw-r--r-- | drivers/staging/slicoss/slicoss.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 16cd2cb4d2cc..51ca17c1f483 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -2646,22 +2646,21 @@ static int slic_upr_request(struct adapter *adapter, u32 upr_data_h, u32 upr_buffer, u32 upr_buffer_h) { - int status; + int rc; spin_lock_irqsave(&adapter->upr_lock.lock, adapter->upr_lock.flags); - status = slic_upr_queue_request(adapter, + rc = slic_upr_queue_request(adapter, upr_request, upr_data, upr_data_h, upr_buffer, upr_buffer_h); - if (status != 0) { - spin_unlock_irqrestore(&adapter->upr_lock.lock, - adapter->upr_lock.flags); - return status; - } + if (rc) + goto err_unlock_irq; + slic_upr_start(adapter); +err_unlock_irq: spin_unlock_irqrestore(&adapter->upr_lock.lock, adapter->upr_lock.flags); - return 0; + return rc; } static void slic_upr_request_complete(struct adapter *adapter, u32 isr) |