aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/slicoss
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-04-04 09:29:42 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-04-05 14:17:00 -0700
commit986d75843555d0f6bc4acd11276c7f8f77d246b8 (patch)
treecc31e5fe93bae575cc498d5870ad06304f0fed5b /drivers/staging/slicoss
parentstaging: csr: info leak in unifi_cfg_get_info() (diff)
downloadlinux-dev-986d75843555d0f6bc4acd11276c7f8f77d246b8.tar.xz
linux-dev-986d75843555d0f6bc4acd11276c7f8f77d246b8.zip
staging: slicoss: information leak in ETHTOOL_GSET
There are some fields in "edata" which have not been cleared. One example is edata.cmd. It leaks uninitialized stack information to the user. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/slicoss')
-rw-r--r--drivers/staging/slicoss/slicoss.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index c8375a26816b..e4b82770ed39 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3149,6 +3149,7 @@ static int slic_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
return -EFAULT;
if (ecmd.cmd == ETHTOOL_GSET) {
+ memset(&edata, 0, sizeof(edata));
edata.supported = (SUPPORTED_10baseT_Half |
SUPPORTED_10baseT_Full |
SUPPORTED_100baseT_Half |