diff options
| author |   Tamara Diaconita <diaconitatamara@gmail.com> | 2017-03-07 18:38:59 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-09 14:29:40 +0100 |
| commit | c9862fe6dd4fc28793ad2fee363d0452c1506da7 (patch) | |
| tree | f000c9b06f6800ca84e9db34a6a558934e19959f /drivers/staging/speakup/kobjects.c | |
| parent | staging: speakup: kobjects: Rearrange headers (diff) | |
| download | linux-dev-c9862fe6dd4fc28793ad2fee363d0452c1506da7.tar.xz linux-dev-c9862fe6dd4fc28793ad2fee363d0452c1506da7.zip | |
staging: speakup: kobjects: Delete comparison
Comparison to NULL is not necessary because 'if' statement tests if
'synth' is NULL anyway.
Delete comparison in 'if' structure to fix the checkpath.pl issue :
CHECK: Comparison to NULL could be written 'synth'.
Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/speakup/kobjects.c')
| -rw-r--r-- | drivers/staging/speakup/kobjects.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index a53628867966..9feb97dfd72b 100644 --- a/drivers/staging/speakup/kobjects.c +++ b/drivers/staging/speakup/kobjects.c @@ -392,7 +392,7 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr, len--; new_synth_name[len] = '\0'; spk_strlwr(new_synth_name); - if ((synth != NULL) && (!strcmp(new_synth_name, synth->name))) { + if (synth && (!strcmp(new_synth_name, synth->name))) { pr_warn("%s already in use\n", new_synth_name); } else if (synth_init(new_synth_name) != 0) { pr_warn("failed to init synth %s\n", new_synth_name); |