diff options
| author |   Tapasweni Pathak <tapaswenipathak@gmail.com> | 2014-09-21 19:22:51 +0530 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-23 13:31:36 -0700 |
| commit | 89021ecc8364e727a24b0683a74515c8ddf308db (patch) | |
| tree | 13f5c268b621bee6a582a53345c688e95fa18073 /drivers/staging/speakup | |
| parent | staging: rtl8192ee: Remove unnecessary return statement (diff) | |
| download | linux-dev-89021ecc8364e727a24b0683a74515c8ddf308db.tar.xz linux-dev-89021ecc8364e727a24b0683a74515c8ddf308db.zip | |
staging: speakup: remove jiffies comparison using time_after_eq()
This patch fixes checkpatch.pl warning in files of speakup
WARNING : Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/speakup')
| -rw-r--r-- | drivers/staging/speakup/speakup_decext.c | 2 | ||||
| -rw-r--r-- | drivers/staging/speakup/speakup_decpc.c | 2 | ||||
| -rw-r--r-- | drivers/staging/speakup/synth.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/speakup/speakup_decext.c b/drivers/staging/speakup/speakup_decext.c index 510ac97b097b..555029036dc2 100644 --- a/drivers/staging/speakup/speakup_decext.c +++ b/drivers/staging/speakup/speakup_decext.c @@ -204,7 +204,7 @@ static void do_catch_up(struct spk_synth *synth) else if (ch <= SPACE) { if (!in_escape && strchr(",.!?;:", last)) spk_serial_out(PROCSPEECH); - if (jiffies >= jiff_max) { + if (time_after_eq(jiffies, jiff_max)) { if (!in_escape) spk_serial_out(PROCSPEECH); spin_lock_irqsave(&speakup_info.spinlock, flags); diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index 693389e41dda..7c9c432e48d9 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -420,7 +420,7 @@ static void do_catch_up(struct spk_synth *synth) else if (ch <= SPACE) { if (!in_escape && strchr(",.!?;:", last)) dt_sendchar(PROCSPEECH); - if (jiffies >= jiff_max) { + if (time_after_eq(jiffies, jiff_max)) { if (!in_escape) dt_sendchar(PROCSPEECH); spin_lock_irqsave(&speakup_info.spinlock, flags); diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 4c47b6d06a9f..f3aa4239dc68 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -122,7 +122,7 @@ void spk_do_catch_up(struct spk_synth *synth) schedule_timeout(msecs_to_jiffies(full_time_val)); continue; } - if ((jiffies >= jiff_max) && (ch == SPACE)) { + if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) { spin_lock_irqsave(&speakup_info.spinlock, flags); jiffy_delta_val = jiffy_delta->u.n.value; delay_time_val = delay_time->u.n.value; |