diff options
| author |   Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-07 14:59:15 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-07 22:02:20 -0700 |
| commit | e89a3370b0aaf197016eceefa2e710517c83e445 (patch) | |
| tree | 392759a6c064a07684f91462b6b891b3199ed120 /drivers/staging/tidspbridge/core/chnl_sm.c | |
| parent | staging: comedi: me4000: convert printk's to dev_printk's (diff) | |
| download | linux-dev-e89a3370b0aaf197016eceefa2e710517c83e445.tar.xz linux-dev-e89a3370b0aaf197016eceefa2e710517c83e445.zip | |
staging: tidspbridge: move the dereference below the NULL test
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/tidspbridge/core/chnl_sm.c')
| -rw-r--r-- | drivers/staging/tidspbridge/core/chnl_sm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index f38950ea2728..16fa3462fbbe 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -94,7 +94,7 @@ int bridge_chnl_add_io_req(struct chnl_object *chnl_obj, void *host_buf, struct dev_object *dev_obj; u8 dw_state; bool is_eos; - struct chnl_mgr *chnl_mgr_obj = pchnl->chnl_mgr_obj; + struct chnl_mgr *chnl_mgr_obj; u8 *host_sys_buf = NULL; bool sched_dpc = false; u16 mb_val = 0; @@ -153,6 +153,7 @@ func_cont: * If DPC is scheduled in process context (iosm_schedule) and any * non-mailbox interrupt occurs, that DPC will run and break CS. Hence * we disable ALL DPCs. We will try to disable ONLY IO DPC later. */ + chnl_mgr_obj = pchnl->chnl_mgr_obj; spin_lock_bh(&chnl_mgr_obj->chnl_mgr_lock); omap_mbox_disable_irq(dev_ctxt->mbox, IRQ_RX); if (pchnl->chnl_type == CHNL_PCPY) { |