aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/vboxvideo/vbox_mode.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-10-11 10:59:41 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-10-11 12:10:32 +0200
commitc00e1d09e3053c6af6a7f6d405b5b455f247d5d4 (patch)
tree2c1c35905c2a630a58acd296abbeb521b82a1d45 /drivers/staging/vboxvideo/vbox_mode.c
parentstaging: mt7621-dma: Delete unused define (diff)
downloadlinux-dev-c00e1d09e3053c6af6a7f6d405b5b455f247d5d4.tar.xz
linux-dev-c00e1d09e3053c6af6a7f6d405b5b455f247d5d4.zip
staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()
We need to unlock before returning on this error path. Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vboxvideo/vbox_mode.c')
-rw-r--r--drivers/staging/vboxvideo/vbox_mode.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index 042e4f384df9..78a9c9b13ff6 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -424,6 +424,7 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
/* pinning is done in prepare/cleanup framebuffer */
src = vbox_bo_kmap(bo);
if (IS_ERR(src)) {
+ mutex_unlock(&vbox->hw_mutex);
DRM_WARN("Could not kmap cursor bo, skipping update\n");
return;
}