aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging/vt6655/card.h
diff options
context:
space:
mode:
authorNam Cao <namcaov@gmail.com>2022-09-12 19:04:31 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-09-24 13:05:24 +0200
commit2a2db520e3ca5aafba7c211abfd397666c9b5f9d (patch)
tree85ecde641976195630ae14fc83471a10ced0a0ad /drivers/staging/vt6655/card.h
parentstaging: rtl8723bs: Add a blank line after declarations (diff)
downloadlinux-dev-2a2db520e3ca5aafba7c211abfd397666c9b5f9d.tar.xz
linux-dev-2a2db520e3ca5aafba7c211abfd397666c9b5f9d.zip
staging: vt6655: fix some erroneous memory clean-up loops
In some initialization functions of this driver, memory is allocated with 'i' acting as an index variable and increasing from 0. The commit in "Fixes" introduces some clean-up codes in case of allocation failure, which free memory in reverse order with 'i' decreasing to 0. However, there are some problems: - The case i=0 is left out. Thus memory is leaked. - In case memory allocation fails right from the start, the memory freeing loops will start with i=-1 and invalid memory locations will be accessed. One of these loops has been fixed in commit c8ff91535880 ("staging: vt6655: fix potential memory leak"). Fix the remaining erroneous loops. Link: https://lore.kernel.org/linux-staging/Yx9H1zSpxmNqx6Xc@kadam/ Fixes: 5341ee0adb17 ("staging: vt6655: check for memory allocation failures") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Signed-off-by: Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220912170429.29852-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vt6655/card.h')
0 files changed, 0 insertions, 0 deletions