diff options
| author |   Karolina Drobnik <karolinadrobnik@gmail.com> | 2021-10-21 10:27:53 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-10-22 11:06:03 +0200 |
| commit | 9da4b50c384c9d0567cedfb2e65d39d8c6b2a674 (patch) | |
| tree | 3e6c25df9260aee77334aee2723e6382230df00d /drivers/staging/vt6655 | |
| parent | staging: r8188eu: remove unused defines and enums (diff) | |
| download | linux-dev-9da4b50c384c9d0567cedfb2e65d39d8c6b2a674.tar.xz linux-dev-9da4b50c384c9d0567cedfb2e65d39d8c6b2a674.zip | |
staging: vt6655: Use named constants when checking preamble type
Compare `preamble_type` to a predefined constant, `PREAMBLE_SHORT`,
instead of a literal in `bb_get_frame_time` and `vnt_get_phy_field`
functions. Thanks to this change, it is clear that we check
the type of a preamble, not just compare it against an arbitrary value.
Remove a redundant comment.
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
Link: https://lore.kernel.org/r/20211021092753.511863-1-karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vt6655')
| -rw-r--r-- | drivers/staging/vt6655/baseband.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 8f9177db6663..84fa6ea3e2e6 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -1717,7 +1717,7 @@ unsigned int bb_get_frame_time(unsigned char preamble_type, rate = (unsigned int)awc_frame_time[rate_idx]; if (rate_idx <= 3) { /* CCK mode */ - if (preamble_type == 1) /* Short */ + if (preamble_type == PREAMBLE_SHORT) preamble = 96; else preamble = 192; @@ -1779,7 +1779,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length, case RATE_2M: count = bit_count / 2; - if (preamble_type == 1) + if (preamble_type == PREAMBLE_SHORT) phy->signal = 0x09; else phy->signal = 0x01; @@ -1792,7 +1792,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length, if (tmp != bit_count) count++; - if (preamble_type == 1) + if (preamble_type == PREAMBLE_SHORT) phy->signal = 0x0a; else phy->signal = 0x02; @@ -1809,7 +1809,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length, ext_bit = true; } - if (preamble_type == 1) + if (preamble_type == PREAMBLE_SHORT) phy->signal = 0x0b; else phy->signal = 0x03; |