diff options
| author |   Tim Collier <osdevtc@gmail.com> | 2018-07-25 20:30:31 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-29 10:08:02 +0200 |
| commit | 318c66d456b81ce15b5e17b551d7db6ecc4aeac6 (patch) | |
| tree | b0de75a1c02fe625a0755ac6a70957831b5983df /drivers/staging/wlan-ng | |
| parent | staging: rtl8188eu: remove unused sreset_get_wifi_status() (diff) | |
| download | linux-dev-318c66d456b81ce15b5e17b551d7db6ecc4aeac6.tar.xz linux-dev-318c66d456b81ce15b5e17b551d7db6ecc4aeac6.zip | |
staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx
Fix checkpatch.pl warning:
"Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rs"
reapable is not used to access h/w directly, so volatile is not
necessary.
>From reading the code, the contexts in which the field may be
updated/accessed across threads are protected by the hw->ctlxq.lock
spinlock, where hw is the device struct, so appears thread-safe.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/wlan-ng')
| -rw-r--r-- | drivers/staging/wlan-ng/hfa384x.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 67a944c0d690..992ebaa1071f 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1176,7 +1176,7 @@ struct hfa384x_usbctlx { enum ctlx_state state; /* Tracks running state */ struct completion done; - volatile int reapable; /* Food for the reaper task */ + int reapable; /* Food for the reaper task */ ctlx_cmdcb_t cmdcb; /* Async command callback */ ctlx_usercb_t usercb; /* Async user callback, */ |