diff options
| author |   Jiang Liu <liuj97@gmail.com> | 2013-06-07 00:07:22 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-06-06 12:12:19 -0700 |
| commit | 6030ea9b35971a4200062f010341ab832e878ac9 (patch) | |
| tree | 4428a72c07715d6c43c9ab2ae92f3e0ba3341b73 /drivers/staging/zram/zram_drv.c | |
| parent | staging: comedi: pcl730: tidy up multi-line comment (diff) | |
| download | linux-dev-6030ea9b35971a4200062f010341ab832e878ac9.tar.xz linux-dev-6030ea9b35971a4200062f010341ab832e878ac9.zip | |
zram: avoid invalid memory access in zram_exit()
Memory for zram->disk object may have already been freed after returning
from destroy_device(zram), then it's unsafe for zram_reset_device(zram)
to access zram->disk again.
We can't solve this bug by flipping the order of destroy_device(zram)
and zram_reset_device(zram), that will cause deadlock issues to the
zram sysfs handler.
So fix it by holding an extra reference to zram->disk before calling
destroy_device(zram).
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/zram/zram_drv.c')
| -rw-r--r-- | drivers/staging/zram/zram_drv.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index d628bd30113c..9057520c0e40 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -727,8 +727,10 @@ static void __exit zram_exit(void) for (i = 0; i < num_devices; i++) { zram = &zram_devices[i]; + get_disk(zram->disk); destroy_device(zram); zram_reset_device(zram); + put_disk(zram->disk); } unregister_blkdev(zram_major, "zram"); |