aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorJérôme Pouiller <jerome.pouiller@silabs.com>2019-12-17 16:14:37 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-18 15:51:05 +0100
commit1a6ae3edcd6ae03a7ea5c08856fe79717d96cfb5 (patch)
tree932642ad1389a13aa9d5ae0ab06c82413eb866b1 /drivers/staging
parentstaging: wfx: ensure that retry policy always fallbacks to MCS0 / 1Mbps (diff)
downloadlinux-dev-1a6ae3edcd6ae03a7ea5c08856fe79717d96cfb5.tar.xz
linux-dev-1a6ae3edcd6ae03a7ea5c08856fe79717d96cfb5.zip
staging: wfx: detect race condition in WEP authentication
Current code has a special case to handle association with WEP. Before to rework the tx data handling, let's try to detect any possible misuse of this code. Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20191217161318.31402-9-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/wfx/queue.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
index c7ee90888f69..680fed31cefb 100644
--- a/drivers/staging/wfx/queue.c
+++ b/drivers/staging/wfx/queue.c
@@ -422,6 +422,7 @@ static bool hif_handle_tx_data(struct wfx_vif *wvif, struct sk_buff *skb,
break;
case do_wep:
wfx_tx_lock(wvif->wdev);
+ WARN_ON(wvif->wep_pending_skb);
wvif->wep_default_key_id = tx_priv->hw_key->keyidx;
wvif->wep_pending_skb = skb;
if (!schedule_work(&wvif->wep_key_work))