diff options
| author |   Rui Miguel Silva <rmfrfs@gmail.com> | 2017-05-12 21:16:13 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-15 11:37:26 +0200 |
| commit | 2c8e3f44f708a89a2c73a25a134af8c23998a2bc (patch) | |
| tree | 182bcf796cf8c75c6035c3a45965c5d698f9198a /drivers/staging | |
| parent | staging: typec: tcpm: Fix Port Power Role field in PS_RDY messages (diff) | |
| download | linux-dev-2c8e3f44f708a89a2c73a25a134af8c23998a2bc.tar.xz linux-dev-2c8e3f44f708a89a2c73a25a134af8c23998a2bc.zip | |
staging: typec: fusb302: do not free gpio from managed resource
When allocating a gpio using the managed resource devm_, we can avoid freeing it
manually. But even if we did it we should use devm_gpio_free.
So, just remove the free of the gpio in the error path.
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Acked-by: Yueyao Zhu <yueyao.zhu@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/typec/fusb302/fusb302.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c index d8b50b49bb2d..ef5cceaa5967 100644 --- a/drivers/staging/typec/fusb302/fusb302.c +++ b/drivers/staging/typec/fusb302/fusb302.c @@ -1663,14 +1663,12 @@ static int init_gpio(struct fusb302_chip *chip) if (ret < 0) { fusb302_log(chip, "cannot set GPIO Int_N to input, ret=%d", ret); - gpio_free(chip->gpio_int_n); return ret; } ret = gpio_to_irq(chip->gpio_int_n); if (ret < 0) { fusb302_log(chip, "cannot request IRQ for GPIO Int_N, ret=%d", ret); - gpio_free(chip->gpio_int_n); return ret; } chip->gpio_int_n_irq = ret; |