diff options
| author |   Jiri Slaby <jslaby@suse.cz> | 2020-02-28 12:54:05 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-28 16:06:49 +0100 |
| commit | 4b70dd57a15d2f4685ac6e38056bad93e81e982f (patch) | |
| tree | 99092eb75291a1ebc0f01c69fc4dac5d73cb8645 /drivers/staging | |
| parent | Linux 5.6-rc3 (diff) | |
| download | linux-dev-4b70dd57a15d2f4685ac6e38056bad93e81e982f.tar.xz linux-dev-4b70dd57a15d2f4685ac6e38056bad93e81e982f.zip | |
vt: selection, push console lock down
We need to nest the console lock in sel_lock, so we have to push it down
a bit. Fortunately, the callers of set_selection_* just lock the console
lock around the function call. So moving it down is easy.
In the next patch, we switch the order.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Fixes: 07e6124a1a46 ("vt: selection, close sel_buffer race")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200228115406.5735-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/speakup/selection.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c index a8b4d0c5ab7e..032f3264fba1 100644 --- a/drivers/staging/speakup/selection.c +++ b/drivers/staging/speakup/selection.c @@ -51,9 +51,7 @@ static void __speakup_set_selection(struct work_struct *work) goto unref; } - console_lock(); set_selection_kernel(&sel, tty); - console_unlock(); unref: tty_kref_put(tty); |