diff options
| author |   Dongxiao Xu <dongxiao.xu@intel.com> | 2009-05-31 14:43:58 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@suse.de> | 2009-06-19 11:00:55 -0700 |
| commit | 8d1c50e9829442be5bc88979d587af2a5ff07e32 (patch) | |
| tree | 7317485e181e29cbf3370ad2df9fba2ab846fbea /drivers/staging | |
| parent | Staging: heci: fix setting h_is bit in h_csr register (diff) | |
| download | linux-dev-8d1c50e9829442be5bc88979d587af2a5ff07e32.tar.xz linux-dev-8d1c50e9829442be5bc88979d587af2a5ff07e32.zip | |
Staging: heci: do not print error when heci_bh_handler is already on workqueue
schedule_work returns 0, if the work is already on the work_queue, else
returns non-zero. Do not print error message if heci_bh_handlerwork was
already on queue.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/heci/interrupt.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/staging/heci/interrupt.c b/drivers/staging/heci/interrupt.c index 3a510ed3a3d2..2a3a01a62bbf 100644 --- a/drivers/staging/heci/interrupt.c +++ b/drivers/staging/heci/interrupt.c @@ -103,10 +103,8 @@ irqreturn_t heci_isr_interrupt(int irq, void *dev_id) PREPARE_WORK(&dev->work, heci_bh_handler); DBG("schedule work the heci_bh_handler.\n"); err = schedule_work(&dev->work); - if (!err) { - printk(KERN_ERR "heci: schedule the heci_bh_handler" - " failed error=%x\n", err); - } + if (!err) + DBG("heci_bh_handler was already on the workqueue.\n"); return IRQ_HANDLED; } @@ -260,10 +258,8 @@ end: PREPARE_WORK(&dev->work, heci_bh_handler); DBG("schedule work the heci_bh_handler.\n"); rets = schedule_work(&dev->work); - if (!rets) { - printk(KERN_ERR "heci: schedule the heci_bh_handler" - " failed error=%x\n", rets); - } + if (!rets) + DBG("heci_bh_handler was already queued.\n"); } else { heci_csr_enable_interrupts(dev); } |